empress / empress/guidemaker

Add an acceptance test for the logic provided by `service:head-data`

Open
#96 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
24
Forks
16
PR merge metrics
No merged PRs in 30d

Description

PR https://github.com/ember-learn/guides-source/pull/1980 on ember-learn/guides-source removes a unit test on `service:head-data`

This service is not provided by `ember-learn/guides-source`, but rather by `empress/guidemaker` and as such, should be tested here.

It should be tested with an acceptance test though, not a unit test, and the logic in test https://github.com/empress/empress-blog/blob/master/tests/acceptance/meta-test.js could should probably be replicated.

This issue is here to remind us that this test should be added at some point, since this service won't be tested anymore once https://github.com/ember-learn/guides-source/pull/1980 gets accepted.

Contributor guide

Open the contributing guide

Research direction

Start by reading the referenced empress-blog test at tests/acceptance/meta-test.js and locating the acceptance-test setup in guidemaker. Add coverage for the service:head-data logic as an acceptance test, and confirm the test passes and covers the behavior that the guides-source unit test removal leaves untested.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.