DLOG_IF_F/DVLOG_IF_F not working on VS2015
- Dominant language
- C++
- Stars
- 1.9k
- Forks
- 280
- Avg merge
- 7m
- Merged PRs (30d)
- 4
Description
Hi,
DLOG_IF_F/DVLOG_IF_F fails compiling on vs2015 if debug is enabled. The preprocessor expansion in vs2015 seems to behave differently than clang 10 and gcc 7 where I am compiling my code on.
I am currently avoiding the problem changing line 988 (https://github.com/emilk/loguru/blob/master/loguru.hpp#L988) to:
```
#define DLOG_IF_F(verbosity_name, cond, ...) LOG_IF_F(verbosity_name, cond, __VA_ARGS__)
#define DVLOG_IF_F(verbosity, cond, ...) VLOG_IF_F(verbosity, cond, __VA_ARGS__)
```
instead of :
```
#define DLOG_IF_F(verbosity_name, ...) LOG_IF_F(verbosity_name, __VA_ARGS__)
#define DVLOG_IF_F(verbosity, ...) VLOG_IF_F(verbosity, __VA_ARGS__)
```
This issue could potentially affect the DCHECK definitions as well but I did not have time to test them.
Hope this can be of any help.
- C
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.