emilk / emilk/loguru

loguru.cpp: warning C4005: 'localtime_r': macro redefinition

Open
#240 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.9k
Forks
280
Avg merge
7m
Merged PRs (30d)
4

Description

When I compile with my Visual Studio (latest version), C++14 compiler, I get this warning:

loguru.cpp(52,1): warning C4005: 'localtime_r': macro redefinition

I checked the old loguru version (like 4 years old), and it was defined in the same place as localtime_x.
So I changed it back to localtime_x (so that the meaning of using localtime stays the same) and the couple of places it uses it I use localtime_x instead of localtime_r, exactly like it was in the old loguru version.

I wonder why it was changed to localtime_r and why I get that warning?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.