emilk / emilk/loguru

possible leaks in add_file function

Open
#234 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.9k
Forks
280
Avg merge
7m
Merged PRs (30d)
4

Description

There is no fclose after fopen for file variable.

```
fflush(file);
//fclose(file)<===missing!!
VLOG_F(g_internal_verbosity, "Logging to '" LOGURU_FMT(s) "', mode: '" LOGURU_FMT(s) "', verbosity: " LOGURU_FMT(d) "", path, mode_str, verbosity);
return true;
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for the add_file function and inspect the fopen, fflush, and return path shown in the issue. Verify the file-resource lifecycle and check existing tests or build instructions for log-file handling. Done means the reported leak is addressed and the project still builds and its relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability-sre
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.