emilk / emilk/loguru

some improvement points

Open
#229 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.9k
Forks
280
Avg merge
7m
Merged PRs (30d)
4

Description

Hi.
I'm using your lib and it's great but some problems exist.
It's a good thing to add #ifndef before NOMINMAX & WIN32_LEAN_AND_MEAN to prevent macro redefinition in environments where those two are defined.
may be add green color to Info verbosity like many other logging libs or provide a way to customize verbosity colors.
and does logging macros by default support c++ types like string or filesystem::path? i tried it, it worked but i get some portability warnings and supporting that types is a good feature.
thanks.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.