emilk / emilk/loguru

Loguru c++ version and mingw64

Open
#103 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
1.9k
Forks
280
Avg merge
7m
Merged PRs (30d)
4

Description

Hi Sir,

When I use mingw64 to compile my code, the following msg. :

C:\Users\Amber\Desktop\tsn-milestone2\module\lib\loguru\loguru.cpp:117:0: warning: "NOMINMAX" redefined
#define NOMINMAX
In file included from C:/msys64/mingw64/include/c++/7.3.0/x86_64-w64-mingw32/bits/c++config.h:533:0,
from C:/msys64/mingw64/include/c++/7.3.0/utility:68,
from C:/msys64/mingw64/include/c++/7.3.0/algorithm:60,
from C:\Users\Amber\Desktop\tsn-milestone2\module\lib\loguru\loguru.cpp:29:
C:/msys64/mingw64/include/c++/7.3.0/x86_64-w64-mingw32/bits/os_defines.h:45:0: note: this is the location of the previous definition
#define NOMINMAX 1

This is a warning msg., but I cannot ensure this will cause some error or not. I include loguru.cpp in CmakeLIst and include loguru.hpp in all my cpp files.

Can I ignore this warning or what can i do??

Thank you.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with loguru.cpp at line 117 and inspect how NOMINMAX is defined when building with mingw64, then compare that with the definition reported from the compiler headers. Review the CMakeLists entry that includes loguru.cpp and the loguru.hpp usage, and confirm the warning is resolved by rebuilding the reported configuration without introducing compilation errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.