emersion / emersion/mako

Cannot use `on-notify` in second pass criteria

Open
#619 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
3.3k
Forks
173
PR merge metrics
No merged PRs in 30d

Description

I'm on v1.10.0

I'm trying to configure mako to play a notification sound for only the first notification in a group. I attempted to do this with:

```
group-by=app-name

[!grouped]
on-notify=exec @mpv@ @notify@

[grouped]
on-notify=none
```

But it always plays a sound. I'm able to use `on-notify` in other criteria, e.g., this mutes the sound when dnd mode is enabled:

```
group-by=app-name
max-history=100
on-notify=exec @mpv@ @notify@

[mode=dnd]
invisible=1
on-notify=none

[app-name=dnd]
invisible=0
on-notify=none
default-timeout=5000
group-by=none
```

I'm also able to apply style options:

```
group-by=app-name

[!grouped]
on-notify=exec @mpv@ @notify@

[grouped]
background-color=#ff0000
on-notify=none
```

Will play a sound for all notifications, but only color grouped notifications red.

Based on this statement from the manpage: "In addition to the set of options at the top of the file, the config file may contain zero or more sections, each containing any combination of the BINDING OPTIONS and STYLE OPTIONS." I didn't expect that second pass criteria would be unable to apply some options.

Is this a misunderstanding on my part? A bug or an expected limitation?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.