emersion / emersion/mako

mako swallows output

Open
#386 2 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
C
Stars
3.3k
Forks
173
PR merge metrics
No merged PRs in 30d

Description

When using

notify-send "foo" 'This is a text.
It is intended to test the line numbers that can be displayed
This is line 3.
This is line 4.
This is line 5.
This is line 6.'

mako will break the second line into two (so far so good) and then just swallow everything from line 3 onwards without further indication. This is particularly problematic if the content of the notification changes if something is left out.

![mako notification with lines cropped](https://user-images.githubusercontent.com/6452205/135613440-c0fdd71a-3178-4f86-977d-761f1e1a4ffa.png)

This can be reconfigured by setting the `height` parameter, but to do that, you'd have to know about this behavior, which is only evident once you suspect it upfront and look it up in `mako(5)`. If a user doesn't, they might get a notification popup that is incomplete without their knowledge.
As Notifications are shrunk anyways to fit the content, the default height parameter could be raised without harm. Alternatively an indicator could be implemented, indicating when output is swallowed. Both approaches would alleviate the issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.