emerleite / emerleite/node-gravatar

Base URL formatted incorrectly

Open
#47 3 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
418
Forks
51
PR merge metrics
No merged PRs in 30d

Description

**var baseURL,fix leading // to instead be https://**
when gravatar url is created via gravatar.url(email) the url is generated as //www.gravatar.com when should be https://www.gravatar.com

line 32 gravatar.js

```javascript
var gravatar = module.exports = {

url: function (email, options, protocol) {
var baseURL = "//www.gravatar.com/avatar/";
if (options && options.cdn) {
baseURL = options.cdn + '/avatar/';
delete options.cdn;
} else {
if (options && options.protocol) protocol = proto(options);
if(typeof protocol !== 'undefined') {
baseURL = protocol ? "https://s.gravatar.com/avatar/" : 'http://www.gravatar.com/avatar/';
}
}
var query = getQueryString(options);
return baseURL + getHash(email) + query;
},
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.