embulk / embulk/embulk

`preview_sample_rows` for Input Plugins

Open
#1,623 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.8k
Forks
206
PR merge metrics
No merged PRs in 30d

Description

Embulk has had a configuration `preview_sample_rows` for preview. It seems like a top-level configuration with preview.

https://github.com/embulk/embulk/blob/v0.11.0/embulk-core/src/main/java/org/embulk/exec/PreviewExecutor.java#L32-L58

It just affects `SamplingPageOutput` when printing the preview result.

https://github.com/embulk/embulk/blob/v0.11.0/embulk-core/src/main/java/org/embulk/exec/PreviewExecutor.java#L126-L140

----

On the other hand, we sometimes wanted to limit the input side especially when the input is potentialy so large. We received a feedback for the JDBC Input Plugins.

https://github.com/embulk/embulk-input-jdbc/pull/251

We may want to consider how we can limit the input in preview from global configurations.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.