embulk / embulk/embulk-standards

The behavior of quote config in the CSV parser different between v0.10.36 and v0.10.37

Open
#40 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

We see a difference in the behavior of the quote config of CSV Parser between 0.10.36 and 0.10.37, namely

In version 0.10.36 if the quote is null, the value is set to no quote
https://github.com/embulk/embulk-standards/blob/v0.10.36/embulk-parser-csv/src/main/java/org/embulk/parser/csv/CsvTokenizer.java#L74

In version 0.10.37 if the quote is null, the value is set to double quote

https://github.com/embulk/embulk-standards/blob/v0.10.37/embulk-parser-csv/src/main/java/org/embulk/parser/csv/CsvParserPlugin.java#L481
https://github.com/embulk/embulk-standards/blob/v0.10.37/embulk-parser-csv/src/main/java/org/embulk/parser/csv/CsvTokenizer.java#L77

Is this change expected? Thanks

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.