emberjs / emberjs/router.js

Consider Transition object being a promise sublcass

Open
#95 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
159
PR merge metrics
No merged PRs in 30d

Description

The Transition object already mimics a thenable via `then` but lacks `catch` and `finally` etc, why not just make it a subclass

https://github.com/tildeio/router.js/blob/master/lib/router/transition.js

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.