emberjs / emberjs/router.js

Invalid messages logged to console

Open
#281 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
159
PR merge metrics
No merged PRs in 30d

Description

Upon upgrading to Ember 3.7.x, I found that the JavaScript console had strange messages being logged from this library, like:
```
Transition #Attempting URL transition to /myroute/123: undefined
Preparing to transition from '' to 'myroute'
0
Transitioned into 'myroute'
0
```

The 1st, 3rd, and 5th, messages all seem to stem from an incorrect check in the ``log`` function at:
https://github.com/tildeio/router.js/blob/master/lib/router/utils.ts#L74

I think ``if (arguments.length === 2)`` should be replaced with ``if (args.length === 2)``.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.