emberjs / emberjs/router.js

Is README.md correct for defining handler lookup function?

Open
#264 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
159
PR merge metrics
No merged PRs in 30d

Description

The README.md file says:

```
router.getHandler = function(name) {
return myHandlers[name];
};
```

This doesn't seem to do anything, but having dug into the library it seems to error on `this.router.getRoute()` not being defined. Should the README.md say that `router.getRoute` needs to be set instead?

With that said, I did change my code to set getRoute, which did stop the error, but my handler is still not being called. Is there a working example anywhere that I could follow?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.