emberjs / emberjs/router.js

Evaluate a new way to compare handlers.

Open
#244 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
159
PR merge metrics
No merged PRs in 30d

Description

(From Slack conversation about #242.)

The comparison function to identify equivalency relies on everything coming in at the same time. We should consider a different approach that allows for piece-wise comparison and setting of things like context.

@rwjblue "proposed" `setContext` as a method, and `matchesContext` to be part of the evaluation function for equivalency.

Something like this would make it a bit easier to split the responsibilities of checking handler identity into manageable bites.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the comparison function used to identify handler equivalency and review the discussion linked from #242. Determine how piece-wise comparison and context handling would fit the proposed setContext and matchesContext responsibilities. Done means the project has a decided approach for splitting handler identity checks, with its equivalency behavior clearly defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.