emberjs / emberjs/rfcs

Make Service objects plain ES classes

Open
#600 18 comments 8 reactions 0 assignees View on GitHub
Seeking Co-author
Dominant language
No language data
Stars
801
Forks
409
PR merge metrics
No merged PRs in 30d

Description

The main purpose of services is to be an injectable singleton. It does not seem to be gaining much by [extending from `FrameworkObject`][1] which [inherits from CoreObject][2]. The main benefit of this hierarchy is the Observable mixin, which provides things like `this.get` and friends. I think somewhere, `Service` also mixes in `Evented`, but I couldn't find it.

[1]: https://github.com/emberjs/ember.js/blob/v3.16.3/packages/@ember/service/index.js#L66
[2]: https://github.com/emberjs/ember.js/blob/v3.16.3/packages/@ember/-internals/runtime/lib/system/object.js#L56-L67

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.