emberjs / emberjs/ember.js

Infinite recursion with willTransition hook and queryParams

Open
#9,818 6 comments 0 reactions 1 assignee Claimed by @machty View on GitHub
bug Query Params Routing
Dominant language
TypeScript
Stars
22.6k
Forks
4.2k
Avg merge
3d 12h
Merged PRs (30d)
15

Description

I have a route with a query parameter with `refreshModel` set to true. The route has a `willTransition` hook, which prompts the user to confirm that they want to navigate away from the route. If the user presses cancel, the transition is aborted using `transition.abort()`. This combination causes the router to enter infinite recursion where the user is presented with the confirm dialog over and over again until they press ok.

JSbin: http://jsbin.com/vuzaxe/1
Steps to reproduce: click one of the colors, press the cancel button on the confirmation dialog

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.