emberjs / emberjs/ember.js

Make rehydration more error tolerant

Open
#21,026 0 comments 1 reaction 0 assignees View on GitHub
glimmervm
Dominant language
TypeScript
Stars
22.6k
Forks
4.2k
Avg merge
3d 12h
Merged PRs (30d)
15

Description

## Given:

glimmer X SSR server, with "rehydration: false"
glimmer X bundle, with "rehydration: true" in main file.

## Expected behaviour:

If we trying to rehydrate DOM without rehydration marks, app should warn about it, and completely replace DOM

## Current behavour:

Rehydration error:
![image](https://user-images.githubusercontent.com/1360552/139663092-aa4eb476-ed9f-4797-a5c6-f490ddef737e.png)

![image](https://user-images.githubusercontent.com/1360552/139663142-eb34cf22-fd57-4a2c-a3fc-fd8eac784de7.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.