emberjs / emberjs/ember.js

[Bug] Wrong assertion when dragging a text node

Open
#20,610 6 comments 0 reactions 0 assignees View on GitHub
@ember/component
Dominant language
TypeScript
Stars
22.6k
Forks
4.2k
Avg merge
3d 12h
Merged PRs (30d)
15

Description

### 🐞 Describe the Bug
Dragging text instead of an HTML element leads to an assertion error. See below in the reproduction.

### 🔬 Minimal Reproduction
Having this HTML:
```html
Some Text Some Link
```

Select everything, hover the text and try dragging it. There will be an assertion failure.

The problem is [here](https://github.com/emberjs/ember.js/blob/v5.5.0/packages/%40ember/-internals/views/lib/system/event_dispatcher.ts#L319). Perhaps the check `target instanceof Element` is overly restrictive.

### 😕 Actual Behavior
An assertion which is wrong.

### 🤔 Expected Behavior
No assertion.

### 🌍 Environment

- Ember: 5.5.0
- Node.js/npm: v21.4.0
- OS: Linux
- Browser: Chromium

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.