emberjs / emberjs/ember.js

Router service's `urlFor` does not include sticky queryparams in generated url

Open
#20,396 3 comments 0 reactions 0 assignees View on GitHub
bug Routing
Dominant language
TypeScript
Stars
22.6k
Forks
4.2k
Avg merge
3d 12h
Merged PRs (30d)
15

Description

### 🐞 Describe the Bug
When generating url with `urlFor` function on router service sticky params are not included in the generated url unlike when doing the same thing with `generateURL` in the private `-routing` service

### 🔬 Minimal Reproduction
1. Go to [Ember twiddle](https://ember-twiddle.com/37a3c415c0d48a37bdee375145d218f9?openFiles=templates.index.sub-route%5C.hbs%2C&route=%2Fsub-route%3Fpage%3D3)
2. press `Go to sub route with page=3` link
3. notice how only the last url generated with `generateURL` includes the sticky param `?page=3` in the url

Also it will only include the sticky param if it is supplied with an empty object as the third argument.

### 😕 Actual Behavior
Sticky params are not included when generating urls with `urlFor`

### 🤔 Expected Behavior
Sticky params to be included when generating urls with `urlFor`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.