emberjs / emberjs/ember.js

[Bug] Route#refresh() results in a transition that cannot be retried if there are dynamic segments

Open
#19,260 1 comment 2 reactions 0 assignees View on GitHub
Routing
Dominant language
TypeScript
Stars
22.6k
Forks
4.2k
Avg merge
3d 12h
Merged PRs (30d)
15

Description

I'm storing a failed transition on route errors and presenting "retry" button in the `application-error` template that calls `failedTransition.retry()`.

Everything works fine, except when the transition error results from a route "refresh", if that route has dynamic segments. In this case `failedTransition.retry()` fails with:
> You didn't provide enough string/numeric parameters to satisfy all of the dynamic segments for route [route name]

Repro Twiddle: https://ember-twiddle.com/6d2f981f6628a3260db8cafd3b3aac0a?openFiles=routes.flopping-route%5C.js%2C

Ember: 3.22.1

Similar (in spirit) to #16992, #16921, #10945

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.