emberjs / emberjs/ember.js

visit API should call replaceURL

Open
#18,512 1 comment 0 reactions 0 assignees View on GitHub
Routing
Dominant language
TypeScript
Stars
22.6k
Forks
4.2k
Avg merge
3d 12h
Merged PRs (30d)
15

Description

The `ApplicationInstance`'s `visit()` API currently calls `setURL`, which calls `pushState()` under the hood. Considering the conversation in #18470 where @rwjblue and @chancancode suggested that the `visit` API is intended for booting an application to a custom route (other than `/`), it seems that `visit()` API should use `replaceURL` instead.

https://github.com/emberjs/ember.js/blob/v3.11.1/packages/%40ember/application/instance.js#L268-L275

Here's an example repo: https://github.com/mehulkar/ember-example-visit-api

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.