emberjs / emberjs/ember.js

Infinite loop when aborting query param transition opting in for refreshModel

Open
#12,473 19 comments 2 reactions 0 assignees View on GitHub
bug Query Params Routing
Dominant language
TypeScript
Stars
22.6k
Forks
4.2k
Avg merge
3d 12h
Merged PRs (30d)
15

Description

The title says it all really. Aborting the transition sends the router into an infinite loop, see here:

http://discuss.emberjs.com/t/transition-abort-with-query-params-does-not-abort-transition/8830

JsBin here: http://emberjs.jsbin.com/luzaca/edit?html,js,console,output
When you hit 'Go to 2' you should get a call stack exceeded error.

The same thing happens in 2.1. Which is not surprising because the bad code is in router.js - https://github.com/tildeio/router.js/blob/master/lib/router/router.js#L33 .

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.