emberjs / emberjs/ember-test-helpers

typeIn helper triggers all key-related events, even if preventDefault is called

Open
#912 2 comments 7 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
188
Forks
254
PR merge metrics
No merged PRs in 30d

Description

The `typeIn` helper always triggers all of the key-related events (`keydown`, `keypress`, `input`, and `keyup`) regardless of whether `event.preventDefault()` was called. This makes the helper work differently than actual browser input in a few cases:

* When a `keydown` handler calls `preventDefault`, only the `keydown` and `keyup` events are triggered
* When a `keypress` handler calls `preventDefault`, an `input` event is not triggered

Calling `preventDefault` in a `keyup` or `input` handler has no effect on which events are triggered.

(Tested with Chrome 84.0.4147.105 and Firefox 79.0.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.