emberjs / emberjs/ember-test-helpers

Add support for waitUntil accepting an async function?

Open
#585 6 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
188
Forks
254
PR merge metrics
No merged PRs in 30d

Description

Hi,
I wanted to use `waitUntil` and pass an async function as the callback.
It looks like this [isn't currently supported](https://github.com/emberjs/ember-test-helpers/blob/27389be9e42b6f1c2c295f8c8d3ba6517f1a80f6/addon-test-support/%40ember/test-helpers/wait-until.ts#L51). Is this something you would be interested in supporting?

If so I can try to open a PR which implements Promise support in `waitUntil`.

Contributor guide

Open the contributing guide

Research direction

Read addon-test-support/@ember/test-helpers/wait-until.ts at line 51 to understand the current callback handling and why async functions are unsupported. Define coverage for Promise-returning callbacks and consider the existing waitUntil behavior; done means async callbacks are accepted without regressing synchronous callback support.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.