emberjs / emberjs/ember-test-helpers

Regression: DOM helpers no longer wait on test waiters unless `ember-test-helpers/wait` is imported

Open
#401 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
188
Forks
254
PR merge metrics
No merged PRs in 30d

Description

I have been attempting to upgrade ember-attacher to ember 3.2 and beyond, but my tests started failing with the new test framework.

Previously, calls on `await click('.stuff')` would wait until all registered test waiters were settled. It appears this is no longer the case. Additionally, merely importing, not using, `ember-test-helpers/wait` (`import wait from 'ember-test-helpers/wait';`) causes tests in that file to pass again. From my sleuthing, importing wait registers the test waiters appropriately.

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.