emberjs / emberjs/ember-test-helpers

RFC 232 tests are slower

Open
#394 3 comments 5 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
188
Forks
254
PR merge metrics
No merged PRs in 30d

Description

I recently upgraded an app to Ember 3.1.4 (from 2.1.8), we also switched to RFC 232 style tests as well (great improvement!). But, we noticed that our test suite run length has more than doubled.

At first I thought we were doing something strange in our app causing the issue, but after a little exploration noticed that it seems to be an inherent issue with the new helpers. Ember twiddle doesn't support the new style tests yet, but I set up an example app, using tests generated from 3.1.4 (RFC 232) and 2.1.8 (moduleFor), and a few just asserting true.

https://github.com/stopdropandrew/ember-rfc232-slow-tests

Here's an example of a typical test run:
![image](https://user-images.githubusercontent.com/6681/42257620-37521924-7f0c-11e8-8ba0-993b14ece056.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.