emberjs / emberjs/ember-test-helpers

render does not reject when rendering fails

Open
#310 15 comments 7 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
188
Forks
254
PR merge metrics
No merged PRs in 30d

Description

I would have expected this test to pass, but it fails with "expected not to get here" in addition to an out-of-band qunit failure for the actual `Compiler Error: not-a-component is not a helper`.

```js
test('render can throw', async function(assert) {
try {
await render(hbs`{{not-a-component x="y"}}`);
} catch (err) {
assert.ok(/not-a-component is not a helper/.test(err.message), "expected to see failure");
}
throw new Error("expected not to get here");
});

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.