emberjs / emberjs/ember-test-helpers

[feature request] pass more information back in error scenarios

Open
#1,352 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
188
Forks
254
PR merge metrics
No merged PRs in 30d

Description

Any strong objections to passing back the `target` along with these messages?

Use case: In case there are multiple clicks in a test, having this extra information makes it easier to find out which test selector failed. This can be also applied to other helpers.

https://github.com/emberjs/ember-test-helpers/blob/ad469d2b23841ba4a0561f356239f1d9ed157157/addon-test-support/%40ember/test-helpers/dom/click.ts#L113

https://github.com/emberjs/ember-test-helpers/blob/ad469d2b23841ba4a0561f356239f1d9ed157157/addon-test-support/%40ember/test-helpers/dom/click.ts#L108

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.