emberjs / emberjs/ember-test-helpers

Breaking change released as a minor version

Open
#1,210 6 comments 8 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
188
Forks
254
PR merge metrics
No merged PRs in 30d

Description

Hey folks 👋

I just got hit by the change https://github.com/emberjs/ember-test-helpers/pull/1185 actually changing behaviour that has broken a test using floating dependencies: https://github.com/GavinJoyce/ember-headlessui/pull/140

Can we back that PR out, release a patch release and then release it as a major version bump?

Contributor guide

Open the contributing guide

Research direction

Review PR #1185 and the downstream ember-headlessui PR #140 to confirm the behavior change and its release impact. Check the repository's release process, then determine whether the change can be reverted for a patch release and reissued in a major version; done means both releases follow the project's versioning policy.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.