emberjs / emberjs/ember-test-helpers

[Maintenance] Extract test setup/teardown helper for dom-using helpers

Open
#1,142 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
188
Forks
254
PR merge metrics
No merged PRs in 30d

Description

Original suggestion: https://github.com/emberjs/ember-test-helpers/pull/1113#discussion_r725155278

What to explore:
- if we can make all the dom-using tests use the same setup/teardown behaviors in a like `setupDomTest(hooks)` style helper.
In particular, this code is repeated everywhere:
```js
if (element) {
element.setAttribute('data-skip-steps', true);
element.parentNode.removeChild(element);
element = undefined;
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.