emberjs / emberjs/ember-string

unfixable deprecation issue [deprecation id: ember-string.add-package]

Open
#370 18 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
4
Forks
14
PR merge metrics
No merged PRs in 30d

Description

```
DEPRECATION: Importing from `@ember/string` without having the `@ember/string` package in your project is deprecated. Please add `@ember/string` to your `package.json [deprecation id: ember-string.add-package] This will be removed in ember-source 5.0.0. See https://deprecations.emberjs.com/v4.x/#toc_ember-string-add-package for more details.
```

After upgrading to ember 4.10, I noticed that I am seeing thousands of this deprecation warnings when my app boots up. I checked and to my surprise I was having `"@ember/string": "^3.0.1"` within `devDependencies` in my `package.json`. A discussion on discord pointed be to @ef4 comment: https://github.com/emberjs/ember-string/issues/235#issuecomment-1061413761
Looks like this is describing a similar issue, where it is unclear which implementation (ember-string vs ember internals) is being used.

Is there anything that can be done other waiting for ember to remove its own implementation, or manually silence deprecation warnings?

Additionally it looks like in this case the deprecation message is quite misleading - however, I guess that is part of ember and not ember-string?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.