emberjs / emberjs/ember-qunit

Route deactivate hook

Open
#514 3 comments 6 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
258
Forks
156
PR merge metrics
No merged PRs in 30d

Description

Hey, just noticed that the route `deactivate` hook runs after a test has completed. In our case, we have the deactivate hook fire off a network request, which throws an error because the test server is already shut down.

Is this expected behavior for how the test harness works? A simple short-term solution is to not fire the network request if in a test environment, but this seems less than ideal.

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.