emberjs / emberjs/ember-qunit

Test isolation validation should include canceling active test waiters in ember-test-watiers

Open
#488 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
258
Forks
156
PR merge metrics
No merged PRs in 30d

Description

The `ember-test-waiters` library will soon [include an API](https://github.com/rwjblue/ember-test-waiters/pull/8) to cancel all pending waiters. This is a similar concept to where we cancel timers if test isolation validation is triggered:

https://github.com/emberjs/ember-qunit/blob/c27964ad9fb61e6c80959ccdfdca145a3c5a1572/addon-test-support/ember-qunit/test-isolation-validation.js#L94-L100

This will help ensure that we don't leak state from one test to another, potentially 'wedging' the test waiters and creating an inconsistent state.

Contributor guide

Open the contributing guide

Research direction

Start in addon-test-support/ember-qunit/test-isolation-validation.js around lines 94–100, where timers are canceled during test isolation validation. Read the linked ember-test-waiters API change for canceling pending waiters, then ensure active test waiters are canceled during validation and verify the existing isolation behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
43/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.