emberjs / emberjs/ember-optional-features

Codemod for `template-only-glimmer-components` doesn't support Addons

Open
#237 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
40
Forks
13
PR merge metrics
No merged PRs in 30d

Description

It appears that the codemod implementation only runs against components in the `app/` directory, which will not work for addons, which store their components in the `addon/` directory and may not re-export them at all (since doing so is dangerous and a bad pattern). In order for addons to successfully enable this feature, the codemod needs to be able to create backing classes for addon components.

https://github.com/emberjs/ember-optional-features/blob/master/features/template-only-glimmer-components.js#L55

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.