ember-learn / ember-learn/guides-source

Description of diff style is incorrect in Quick Start

Open
#2,090 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
HTML
Stars
161
Forks
512
Avg merge
4d 9h
Merged PRs (30d)
4

Description

https://guides.emberjs.com/release/getting-started/quick-start/ [here in code] (https://github.com/ember-learn/guides-source/blob/master/guides/release/getting-started/quick-start.md?plain=1#L257 ) describes the diff style:

> In the rest of the code examples in this tutorial, whenever we add or remove code, we will show a "diff." The lines you need to remove have a minus sign in front of them, and the lines you should add have a plus sign. If you are using a screen reader while you go through the Guides, we recommend using Firefox and NVDA or Safari and VoiceOver for the best experience.

However, the diffs display only with colors:

Image

There are no pluses or minuses in the elements either.

I suspect this may not be accessible to those with colorblindness.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.