ember-learn / ember-learn/guidemaker-ember-template

mainmatter/continue-on-error-comment fails on PRs

Open
#207 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5
Forks
23
Avg merge
3m
Merged PRs (30d)
3

Description

`mainmatter/continue-on-error-comment` fails on PRs with `Error: Resource not accessible by integration`

https://github.com/mainmatter/continue-on-error-comment#permissions says to set d

```
permissions:
pull-requests: write
```

but that is true in this workflow already and it is not working.

It alternatively suggests using `pull_request_target` but that is not safe to do in any workflow that runs code from the PR.

I think the best way to run it would be to have another workflow that runs on `pull_request_target` that checks the results of the CI workflow.

Contributor guide

Open the contributing guide

Research direction

Inspect the existing CI workflow that invokes mainmatter/continue-on-error-comment and reproduce the Resource not accessible by integration error. Review the action's permissions guidance and the security implications of pull_request versus pull_request_target. Done means PR results can be commented on without running untrusted PR code in a privileged workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.