ember-learn / ember-learn/ember-cli-addon-docs

Security vulnerability: Update packages cryptiles and mime

Open
#339 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
172
Forks
142
PR merge metrics
No merged PRs in 30d

Description

This project depends on vulnerable versions of `cryptiles` and `mime`.

Cryptiles: [CVE-2018-1000620](https://nvd.nist.gov/vuln/detail/CVE-2018-1000620)
Mime: [CVE-2017-16138](https://nvd.nist.gov/vuln/detail/CVE-2017-16138)

It would probably also be a good idea to turn on automated checks for insecure dependencies.

Yarn [resolutions](https://yarnpkg.com/lang/en/docs/selective-version-resolutions/) may be helpful here. For us, pinning `request` to [2.87.0](https://github.com/request/request/pull/2943#issuecomment-390577329) seems to fix this (`request` is the source of the `cryptiles` and `mime` dependencies).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.