ember-learn / ember-learn/ember-cli-addon-docs

Block components contents clobbered into text only

Open
#236 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
172
Forks
142
PR merge metrics
No merged PRs in 30d

Description

This code: https://github.com/ember-learn/ember-cli-addon-docs/blob/b4bfe91ad58406808b960fc1870d571b16b462a4/lib/utils/compile-markdown.js#L28-L54 prevents the use of block components to yield to Markdown.

This leads to it being impossible to wrap the Markdown in a component to provide a highlight. For example, this does not work:

```
{{#highlight-this for='engineering'}}

#### Note

I don't recommend actually eating this pineapple.

{{/highlight-this}}
```

Instead of clobbering the markup, can we instead try to preserve it as much as possible?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.