ember-learn / ember-learn/cli-guides

Show the ember-cli logo above the TOC

Open
#81 3 comments 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
26
Forks
77
Avg merge
9m
Merged PRs (30d)
2

Description

For the cli-guides we should show the ember-cli logo in the top left just above the TOC.

screenshot 2018-12-11 at 11 18 08

As we are using guidemaker for the ember-cli guides we will need to make this a configurable feature of the [guidemaker-ember-template](https://github.com/ember-learn/guidemaker-ember-template) so that any other projects using the same template can optionally configure this logo

### Todo

- [ ] add a configuration entry for `logo` to the guidemaker block of the cli-guides https://github.com/ember-learn/cli-guides/blob/master/config/environment.js#L33
- I guess it doesn't really need to be in the guidemaker block 🤔 but it needs to be somewhere in that config
- [ ] if the logo is configured it should be used in the template above the TOC
- it might be worth putting it in this file that renders the left column: https://github.com/ember-learn/guidemaker-ember-template/blob/master/app/templates/version.hbs

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.