ember-fastboot / ember-fastboot/fastboot

Move Application and ApplicationInstance creation into VM sandbox

Open
#244 0 comments 1 reaction 1 assignee Claimed by @rwjblue View on GitHub
enhancement
Dominant language
No language data
Stars
155
Forks
67
PR merge metrics
No merged PRs in 30d

Description

Currently, we do a few things in the node process (instead of within the sandbox context):

* Require the application factory (`require('~fastboot/app-factory')`)
* Create the application factory (`AppFactory.default()`)
* Boot the application (`app.boot()`)
* Create an application instance instance (`app.buildInstance()`)
* Boot the application instance instance (`instance.boot()`)
* Invoke `instance.visit`

Everything in this list _except_ the last item should actually be done within the sandboxed VM context instead. This will allow these steps to be further optimized and shared across visits (since the VM scripts we evaluate share bytecode and compilation information), and it will also significantly improve the prototype extension compatibility (#170).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.