ember-fastboot / ember-fastboot/fastboot

Refactor `destroyAppInstanceInMs` system

Open
#240 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
No language data
Stars
155
Forks
67
PR merge metrics
No merged PRs in 30d

Description

Currently, the `visit` promise is not entangled with the timeout at all, and the timeout is used to set the `result.error` object. Instead, we should refactor so that when the timeout expires the current `visit` is "canceled" (essentially calling `.destroy()` on the underlying ember application that is being booted/visited) and reject the `visit` promise.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.