ember-fastboot / ember-fastboot/fastboot

Support Prototype Extensions

Open
#170 5 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
No language data
Stars
155
Forks
67
PR merge metrics
No merged PRs in 30d

Description

fastboot currently [builds the application instance outside of the vm](https://github.com/ember-fastboot/fastboot/blob/master/src/ember-app.js#L224-L229) from within [visitRoute](https://github.com/ember-fastboot/fastboot/blob/master/src/ember-app.js#L249-L263)

`visitRoute` currently utilizies the sandbox indirectly, via `this.app` which is created from an app factory returned from the sandbox.

If, instead, `visitRoute` delegated its work to a function run within the sandbox context, prototype extensions would work (or at least an impediment to their working would be removed).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.