ember-fastboot / ember-fastboot/fastboot

undefined value in shoebox throws error

Open
#137 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
No language data
Stars
155
Forks
67
PR merge metrics
No merged PRs in 30d

Description

If you accidentally provide an `undefined` as a shoebox value, you get the stack trace:
```
TypeError: Cannot read property 'replace' of undefined
at escapeJSONString (/xxx/node_modules/fastboot/src/ember-app.js:478:16)
at createShoebox (/xxx/node_modules/fastboot/src/ember-app.js:453:17)
at visitRoute.then.then (/xxx/node_modules/fastboot/src/ember-app.js:316:11)
```

It would be easy to handle undefined and ignore them.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.