ember-fastboot / ember-fastboot/fastboot-website

Missing dependencies in code example for 3rd party dependencies

Open
#105 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
19
Forks
49
PR merge metrics
No merged PRs in 30d

Description

Under Addon Authors guide, for Third Party Dependencies,
We need to include Funnel and mergeTrees dependencies

## CURRENT
```js
var map = require('broccoli-stew').map;

treeForVendor(defaultTree) {
var browserVendorLib = new Funnel();

browserVendorLib = map(browserVendorLib, (content) => `if (typeof FastBoot === 'undefined') { ${content} }`);

return new mergeTrees([defaultTree, browserVendorLib]);
}

included() {
// this file will be loaded in FastBoot but will not be eval'd
app.import('vendor/.js');
}
```
## EXPECTED
```js
var map = require('broccoli-stew').map;
var Funnel = require('broccoli-funnel');
var mergeTrees = require('broccoli-merge-trees');

treeForVendor(defaultTree) {
var browserVendorLib = new Funnel();

browserVendorLib = map(browserVendorLib, (content) => `if (typeof FastBoot === 'undefined') { ${content} }`);

return new mergeTrees([defaultTree, browserVendorLib]);
}

included() {
// this file will be loaded in FastBoot but will not be eval'd
app.import('vendor/.js');
}
```
Example code referred from
https://github.com/soulim/ember-cli-bootstrap-datepicker/pull/100/files#diff-168726dbe96b3ce427e7fedce31bb0bcR7

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.