ember-fastboot / ember-fastboot/fastboot-aws

Tricky behavior around build zip filenames

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
50
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Because of the [logic that fastboot-s3-downloader uses](https://github.com/tomdale/fastboot-s3-downloader/blob/master/index.js#L128) to extract output path from zip file names, any .zip filename without a dash in it will cause fastboot-aws to proceed with an outputPath of `""` ultimately resulting in rimraf crashing when it tries to delete a path of `""`.

The error message the user gets is fairly cryptic (pretty sure this is the exact quote: `something something rimraf became unhappy`)

I suggest a few courses of action
- in the instructions for fastboot-aws on ebs setup, mention that the filename should be something fairly consistent with the expected pattern (i.e., `dist-0.zip`)
- add a few asserts along the way -- particularly considering that once you have your asset serving layer running on EBS, pulling the logs is not effortless, and in fact cannot be done while an environment is busy doing anything else at all.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.