ember-fastboot / ember-fastboot/fastboot-app-server
Workers can't recover from no `distPath`.
- Dominant language
- No language data
- Stars
- 140
- Forks
- 70
- PR merge metrics
- No merged PRs in 30d
Description
Workers are `started` just once:
https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/fastboot-app-server.js#L53
`this.middleware` is only set here:
https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/worker.js#L45-L49
And then you're stuck with that `middleware` forever:
https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/worker.js#L87
For bonus points, `fastbootMiddleware` here:
https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/express-http-server.js#L26
...is therefore possibly *not* a FastBoot middleware which is a super troll since we expose `httpServer` as a downstream API.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.