ember-fastboot / ember-fastboot/ember-cli-head

Glimmer rehydration causing title to have <!--%+b:10%-->

Open
#55 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
97
Forks
35
Avg merge
3h 3m
Merged PRs (30d)
6

Description

Before the render finishes, during the afterModel hook, my DOM looks like this:

```html

<!--%+b:10%-->My Super Project Title<!--%-b:10%-->


```

Which is causing the title of the tab to momentarily be ``

I just upgraded to Ember 2.5.1:

```
DEBUG: -------------------------------
vendor.js:17027 DEBUG: Ember : 3.5.1
vendor.js:17027 DEBUG: Ember Data : 3.5.0
vendor.js:17027 DEBUG: jQuery : 3.3.1
vendor.js:17027 DEBUG: Ember Simple Auth : 1.7.0
vendor.js:17027 DEBUG: -------------------------------
```

The issue seems to be described here: https://github.com/glimmerjs/glimmer-vm/issues/796

The suggested fix is to use triple curlies in the `in-element` component. Which seems bad.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.