ember-fastboot / ember-fastboot/ember-cli-head

DEPRECATION: Importing inject from @ember/service is deprecated. Please import service instead.

Open
#119 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
97
Forks
35
Avg merge
3h 3m
Merged PRs (30d)
6

Description

After updating our app from Ember 5.12 to Ember 6.4 we're seeing the following deprecation warnings coming from this add-on:

```
DEPRECATION: Importing `inject` from `@ember/service` is deprecated.
Please import `service` instead.
[deprecation id: importing-inject-from-ember-service]
This will be removed in ember-source 7.0.0.
See https://deprecations.emberjs.com/id/importing-inject-from-ember-service for more details.
```

These lines should be updated:

- https://github.com/ember-fastboot/ember-cli-head/blob/master/addon/components/head-layout.js#L2
- https://github.com/ember-fastboot/ember-cli-head/blob/master/app/components/head-content.js#L1

The docs indicate:

> If you're working on a library that needs to support ember-source prior to 4.1, you can support both styles of service via:

```ts
import * as emberService from '@ember/service';

const service = emberService.service ?? emberService.inject;
```

@mansona Would you be open to accept a PR with this change?

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.