ember-fastboot / ember-fastboot/ember-cli-fastboot

Figure out why some tests need application-template-wrapper enabled to pass

Open
#838 0 comments 0 reactions 0 assignees View on GitHub
good first issue Good for New Contributors test
Dominant language
JavaScript
Stars
850
Forks
161
Avg merge
17h 45m
Merged PRs (30d)
19

Description

As part of my work to [upgrade ember-cli-fastboot using ember-cli-update](https://github.com/ember-fastboot/ember-cli-fastboot/pull/834) I noticed that some tests failed because they needed the application-template-wrapper to be enabled in optitonal-features.

I didn't really have the time to investigate why, and I didn't want to block the other PR any more than it already was 🙈 so this issue is to keep track that it needs to be looked into.

To test this, just undo the work in [this commit](https://github.com/ember-fastboot/ember-cli-fastboot/pull/834/commits/b7c393470773119b1fd21a7e538a8f560c62530c) and see why some tests fail 🤷 I have a feeling it could just be a selector depending on the wrapper div existing 🤔

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.